if you make a sub submerge, does it still convoy? I just kinda assumed it does.
You mean disrupt convoy?
Yes, it does. The decision to submerge is a decision for the Conduct Combat Phase only.
Physically it is removed from the battle strip and placed back on the map.
Convoy disruption takes place later in the Collect Income phase.